-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure merge transition block contains 🐼 #2875
The head ref may contain hidden characters: "\u{1F43C}"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐼
I really appreciate the Idea. Feels strange that this hasn't been in the specs since beginning... Edit: |
|
Given the importance of graffitis for representing significant moments in blockchain history, e.g., Bitcoin and beacon chain genesis blocks, the merge transition block's graffiti MUST refer to the panda as the universally agreed mascot. This patch ensures that all implementations adhere to this convention. Co-authored-by: dapplion <35266934+dapplion@users.noreply.github.com>
I really appreciate the effort! Imagine the Merge is stumbling because proposers are failing to put panda into the right place 😂 Btw, PR misses corresponding changes to |
When building `BeaconBlockBody`, if the configured `graffiti` is not compatible with the fork choice rules for the merge transition block, build a regular block without `ExecutionPayload` instead.
|
Just tell Mr. F. to change his graffiti. |
The nice thing about this PR is that individual node operators, and even consensus layer implementations, can opt-in to support it on their own. Having a Regarding the consensus-layer rule: The way how it is proposed here is simple enough to implement, and makes inconsistencies between different Unicode libraries irrelevant – it is a simple check against a static sequence of data, and it does not interpret the graffiti as UTF-8 or run expensive string validation. It could be fun to see both false-negatives of people trying to apply skin-tone modifiers to other bears and getting rejected for trying to be too smart, or false-positives of people trying to make the panda-sequence appear as part of other characters but rely on different segmentation to have it actually rendered differently. In the end, the miners are able to collaborate and decrease global hashrate to push the TTD far into the future (they would still have to buy up all the GPU stock to avoid others pumping hashrate), and with the panda PR, stakers could then proceed to delay the merge by avoiding the panda, because maybe they want to finish pruning their EL or whatever. This moves the authority to answer "when merge" entirely to the community (for both the EL and the CL). 🐼 |
Since @etan-status has not mentioned this is a joke, I will provide some feedback under the assumption that this PR is not a joke. While I appreciate the effort to continue the panda meme, I think that having a spec level enforcement is an unnecessary complexity addition. It's another thing that could go wrong during launch. When thinking about the risk vs reward of this change, I do not think this spec level assertion to enforce the meme is worth any potential issues that may arise. With that said, if the first block proposer does not include a panda emoji then I will be deeply disappointed. 🐼 |
On the other hand, allowing non-panda merge transition blocks would enable panda maxis to potentially trigger heavy forking around the transition period by orphaning those branches that they deem unviable. This PR mitigates this risk by allowing non-panda blocks to continue build a canonical chain as usual, until a panda is found. Should we really trust node operators who are unable to properly configure their graffiti with such a critical role during the PoS upgrade process? 🐼 |
Resolve merge conflicts from fixes being accepted into `dev` that have been discovered as part of 🐼 work: #2876
panda.mov |
🐼 art has been integrated into Nimbus: status-im/nimbus-eth2#3670 |
🐼 viewing in Windows command prompt, or Linux/macOS Terminal:
(there is no |
closing due to insurmountable complexity and liveness issues |
** sad panda sounds ** |
GitHub has added a little banner on top of PRs from branches containing emoji (and Unicode RTL-overrides!), and appears to also have fixed the display of pandas in the little messages through the conversation when force-pushing such branches. |
Given the importance of graffitis for representing significant moments in blockchain history, e.g., Bitcoin and beacon chain genesis blocks, the merge transition block's graffiti MUST refer to the panda as the universally agreed mascot. This patch ensures that all implementations adhere to this convention.